From a02988fb3a9557ea0ce473a870ef8670aeb3e054 Mon Sep 17 00:00:00 2001 From: jichangjun Date: Sat, 5 Sep 2020 18:49:29 +0800 Subject: [PATCH] add more case for filterProfile method --- pkg/cover/client_test.go | 2 +- pkg/cover/server_test.go | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/pkg/cover/client_test.go b/pkg/cover/client_test.go index ab06402..1663599 100644 --- a/pkg/cover/client_test.go +++ b/pkg/cover/client_test.go @@ -36,7 +36,7 @@ func TestClientAction(t *testing.T) { profileMockResponse := []byte("mode: count\nmockService/main.go:30.13,48.33 13 1\nb/b.go:30.13,48.33 13 1") profileSuccessMockSvr := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) - w.Write(profileMockResponse) + _, _ = w.Write(profileMockResponse) })) defer profileSuccessMockSvr.Close() diff --git a/pkg/cover/server_test.go b/pkg/cover/server_test.go index d53fb61..62b75d4 100644 --- a/pkg/cover/server_test.go +++ b/pkg/cover/server_test.go @@ -287,6 +287,16 @@ func TestFilterProfile(t *testing.T) { }, }, }, + { + name: "with invalid regular expression", + pattern: []string{"(?!a)"}, + input: []*cover.Profile{ + { + FileName: "some/fancy/gopath/a.go", + }, + }, + expectErr: true, + }, } for _, tc := range tcs {